No. You are not doing anything wrong. Pennsylvania does not tax unemployment but New York does.
Any unemployment benefits your son receives while living in NY (even if it comes from PA) is taxed by NY.
NY taxes part-year residents on all income, unless exempt, while they live in NY.
**Say "Thanks" by clicking the thumb icon in a post
**Mark the post that answers your question by clicking on "Mark as Best Answer"