"If he simply transferred your holdings from your investment account into your IRA, then there would be no tax on the portion that represents the basis."
This is not permitted. Regular contributions to an IRA must be in cash. (And this cannot be an in-kind rollover contribution since the shares did not come from a qualified retirement account.)
