"So the big question is what is cost/benefit of grantor/non-grantor now that the tax laws changed?"
Legal - assets in a non-grantor trust are potentially shielded from judgment creditors (and others) whereas assets in a typical grantor trust are not (since the judgment debtor is treated as the owner of the assets).
That is a huge difference and, in addition to avoiding probate, one of the primary reasons for setting up the entity.
