@Cart0910 :
Once you move to PA, ALL your income becomes taxable by PA, regardless of its source.
If you continue to work in NY after moving to PA, your income from working in NY (or from working remotely in PA for your own convenience for a NY employer) will also be taxable by NY. In that circumstance you'd file a non-resident NY tax return in addition to your home state PA tax return. You'd be able to take a credit on your PA return for the taxes paid to NY on the income taxed by both states, so you wouldn't be double-taxed. But the amount of the credit would not exceed what your PA tax bill would have been if the entire amount had been taxed only by PA.
In the year that you move, you'd file as a part-year resident of each of the two states.
**Answers are correct to the best of my ability but do not constitute tax or legal advice.
