NY defines you as a resident for tax purposes if your domicile (your main, permanent home) is outside NY, but you maintain a permanent place of abode in NY for more than 11 months of the year and spend 184 days or more in NY during the tax year.
https://www.tax.ny.gov/pit/file/pit_definitions.htm#ppa From your description of your circumstances, your 2018 domicile was in PA. You did have a "permanent place of abode" in NY because your unsold NY house meets that definition. But you did not maintain it for more than 11 months. Therefore you were not an NY resident in 2018 and my previous instruction remains valid.
**Answers are correct to the best of my ability but do not constitute tax or legal advice.
