To add a bit to @Hal_Al 's answer, you're a resident of New York for tax purposes as long as your domicile is in New York. This New York tax reference clarifies the meaning of domicile:
https://www.tax.ny.gov/pit/file/pit_definitions.htm#domicile
New York taxes its residents on all their income, regardless of where earned.
**Answers are correct to the best of my ability but do not constitute tax or legal advice.
